-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pr template, add pr checks and label checks #2804
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
We should also check that a ticket has been linked to the PR |
I think whether that is required should be decided in a discussion on ways of working etc. For example this PR doesn't currently have a ticket as it was a bit ad hoc. Is that something we want to allow for? Or are we saying every PR needs to have a ticket? I think obviously the ticket should be linked if there is one but my opinion is I don't think that needs to be absolutely mandatory because the PR can serve as documentation itself by adding it to the board as a ticket essentially, whereas the other things in this PR should be because they make a difference to our release documentation and keeping the board up to date with the work that is going on. Happy to discuss |
…l/design-system into add-pr-checks-and-label-checks
What is the context of this PR?
This PR adds the label and task checker github actions and updates the PR template. This will ensure we set all the correct data on a PR before it can be merged. Also updates the release template to include some new labels.
How to review this PR
Checklist
This needs to be completed by the person raising the PR.