Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pr template, add pr checks and label checks #2804

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Sep 14, 2023

What is the context of this PR?

This PR adds the label and task checker github actions and updates the PR template. This will ensure we set all the correct data on a PR before it can be merged. Also updates the release template to include some new labels.

How to review this PR

  • Tasks pass
  • Removing the label or unchecking a task causes the tasks to fail

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Project for this PR (Design System) and selected the correct status
  • I have selected the correct Assignee
  • I have linked the correct Issue

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit e8eee93
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/650aff11e09b58000803fe01
😎 Deploy Preview https://deploy-preview-2804--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar self-assigned this Sep 14, 2023
@rmccar rmccar added Enhancement Change of existing feature Documentation Documentation content or feature for the design system website and removed Enhancement Change of existing feature Documentation Documentation content or feature for the design system website labels Sep 14, 2023
@precious-onyenaucheya-ons
Copy link
Contributor

We should also check that a ticket has been linked to the PR

@rmccar
Copy link
Contributor Author

rmccar commented Sep 18, 2023

We should also check that a ticket has been linked to the PR

I think whether that is required should be decided in a discussion on ways of working etc. For example this PR doesn't currently have a ticket as it was a bit ad hoc. Is that something we want to allow for? Or are we saying every PR needs to have a ticket? I think obviously the ticket should be linked if there is one but my opinion is I don't think that needs to be absolutely mandatory because the PR can serve as documentation itself by adding it to the board as a ticket essentially, whereas the other things in this PR should be because they make a difference to our release documentation and keeping the board up to date with the work that is going on. Happy to discuss

@rmccar rmccar merged commit 6d5e003 into main Sep 20, 2023
@rmccar rmccar deleted the add-pr-checks-and-label-checks branch September 20, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation content or feature for the design system website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants